feat: removed wallet_getCapabilities #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-doshi
requested review from
onbjerg,
Rjected and
mattsse
as code owners
|
There are 2 ways we can set the address in the capabilities var:
|
onbjerg
requested changes
Nov 28, 2024
crates/e2e-tests/src/tests.rs
Outdated
Comment on lines
60
to
74
| let capabilities = { | ||
| let mut innermost_tree = BTreeMap::new(); | ||
| innermost_tree.insert( | ||
| "addresses".to_string(), | ||
| vec![Address::from_str(&std::env::var("DELEGATION_ADDRESS").unwrap()).unwrap()], | ||
| ); | ||
|
|
||
| let mut inner_tree = BTreeMap::new(); | ||
| inner_tree.insert("delegation".to_string(), innermost_tree); | ||
|
|
||
| let mut capabilities = BTreeMap::new(); | ||
| capabilities.insert(chain_id, inner_tree); | ||
|
|
||
| capabilities | ||
| }; |
There was a problem hiding this comment.
we should remove the capabilities structs entirely, we don't need them anymore, and instead use a const address here or an env var
There was a problem hiding this comment.
Just to clarify, you mean to remove WalletCapabilities right?
#[derive(Debug, Clone, Eq, PartialEq, Deserialize, Serialize)]
pub struct WalletCapabilities(pub HashMap<U64, Capabilities>);
I see its not really being used anywhere else in the code
|
@varun-doshi looks good overall, some lints are failing PTAL |
onbjerg
requested changes
Dec 4, 2024
onbjerg
requested changes
Dec 4, 2024
Understood |
|
Opened new PR with correct branch #110 |
onbjerg
added a commit
that referenced
this pull request
Dec 5, 2024
Closes #99 Removed `get_capabilities` from the `WalletCapabilities` trait In `e2e_tests` the capabilities is initialised manually with the contract address being pulled in from `env` variables. Related PR: #104 (review) --------- Co-authored-by: Oliver Nordbjerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99
Removed
get_capabilitiesfrom theWalletCapabilitiestraitIn
e2e_teststhe capabilities is initialised manually with the contract address being pulled in fromenvvariables.